Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][22.3] Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. #5392

Closed
wants to merge 1 commit into from
Closed

[Backport][22.3] Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. #5392

wants to merge 1 commit into from

Conversation

galderz
Copy link
Contributor

@galderz galderz commented Nov 8, 2022

Backport fix for #5303 for 22.3 branch.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 8, 2022
@galderz galderz mentioned this pull request Nov 8, 2022
Closed
zakkak
zakkak approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is a clean backport of 62432ef

@zakkak zakkak requested a review from ezzarghili November 8, 2022 17:14
@zakkak zakkak mentioned this pull request Nov 8, 2022
Closed
@ezzarghili
Copy link
Member

@oubidar-Abderrahim Please coordinate with @marwan-hallaoui on internal integration for this PR.

@ezzarghili ezzarghili changed the title Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. [Backport][22.3.1] Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. Nov 14, 2022
@ezzarghili ezzarghili changed the title [Backport][22.3.1] Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. [Backport][22.3] Fallback from PosixPerfMemoryProvider to CHeapPerfMemoryProvider. Nov 14, 2022
ezzarghili
ezzarghili requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@ezzarghili ezzarghili left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When cherry-picking commits, please use the -X flag to retain the original commit reference.

@galderz galderz force-pushed the topic.1108.memory-provider-fallback branch from 996874b to 3922a52 Compare November 17, 2022 10:48
@galderz
Copy link
Contributor Author

galderz commented Nov 17, 2022

@ezzarghili You mean -x rather than -X? I've just pushed again having passed -x.

@jerboaa
Copy link
Collaborator

jerboaa commented Nov 22, 2022

Any update on this? Can we assume this makes it into 22.3.1?

@ezzarghili
Copy link
Member

The PR is merged into our CPU branched internally, they will show up once they get mirrored to GitHub.

@ezzarghili ezzarghili self-requested a review November 24, 2022 11:31
@jerboaa
Copy link
Collaborator

jerboaa commented Nov 24, 2022

Thanks!

@oubidar-Abderrahim
Copy link
Member

You mean -x rather than -X? I've just pushed again having passed -x.

Sorry @galderz, I started the integration process before this change and missed it. The backport was integrated in the 22.3 branch here: 45bf93a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezzarghili ezzarghili ezzarghili approved these changes

@zakkak zakkak zakkak approved these changes

@peter-hofer peter-hofer Awaiting requested review from peter-hofer

Assignees

@ezzarghili ezzarghili

Labels
backport OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@galderz @ezzarghili @jerboaa @oubidar-Abderrahim @zakkak @peter-hofer